Skip to content

gke-gateway v0.5.0 conformance test report 9/9 #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 22, 2025
Merged

gke-gateway v0.5.0 conformance test report 9/9 #1005

merged 12 commits into from
Jul 22, 2025

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jun 17, 2025 •
edited
Loading

gke-gateway conformance tests running against against prod gke-gateway

Currently have to manually modified the GatewayAPIInferenceExtensionVersion to v0.5.0, this will be resolved after #1214 is merged.

@robscott

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 17, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 106ec14
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/687ff5767e99740008a3b673
😎 Deploy Preview https://deploy-preview-1005--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2025
@zetxqx

This comment was marked as off-topic.

Sign in to view
@nirrozenbaum nirrozenbaum added the gie-area/conformance Categorizes an issue or PR as relevant to GIE conformance tests. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2025
@zetxqx zetxqx changed the title [WIP] Sample conformance report. [WIP] gke-gateway dev-cluster v0.4.0 report 9/9 Jul 7, 2025
@zetxqx zetxqx changed the title [WIP] gke-gateway dev-cluster v0.4.0 report 9/9 gke-gateway dev-cluster v0.4.0 conformance test report 9/9 Jul 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
robscott
robscott approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zetxqx!

nirrozenbaum
nirrozenbaum reviewed Jul 7, 2025
View reviewed changes
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2025
@zetxqx zetxqx marked this pull request as draft July 7, 2025 18:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@zetxqx zetxqx changed the title gke-gateway dev-cluster v0.4.0 conformance test report 9/9 gke-gateway dev-cluster v0.5.0-dev conformance test report 9/9 Jul 10, 2025
@zetxqx zetxqx changed the title gke-gateway dev-cluster v0.5.0-dev conformance test report 9/9 gke-gateway v0.5.0 conformance test report 9/9 Jul 22, 2025
@zetxqx zetxqx requested review from nirrozenbaum and robscott July 22, 2025 20:28
@zetxqx zetxqx marked this pull request as ready for review July 22, 2025 20:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025
nirrozenbaum
nirrozenbaum approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

left one nit, definitely not a blocker.

conformance/reports/v0.5.0/gateway/gke-gateway/README.md
1. Create a GKE cluster with Gateway API enabled.

```
gcloud container clusters create "${cluster_name}" --gateway-api=standard --location="${location}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: variables ${cluster_name} and ${location} were not defined or referred anywhere before this line, so it could be a bit unclear for a newcomer.

do you have them defined somewhere out of this PR?
definitely not a blocker and we can make progress and come back to this if/when needed.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, robscott, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1036d80 into kubernetes-sigs:main Jul 22, 2025
9 checks passed
@zetxqx zetxqx deleted the report branch July 24, 2025 21:39
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
@zetxqx @kfswain
gke-gateway v0.5.0 conformance test report 9/9 (kubernetes-sigs#1005)
02a4001 
* generate first test report.

* new versino.

* add real report.

* refine report parameters.

* refine report parameters.

* update report format.

* update report format.

* update report.

* update report.

* remove unneeded change.:

* remove unneeded change.:

* remove unneeded change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum approved these changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@robscott robscott Awaiting requested review from robscott

Assignees

@nirrozenbaum nirrozenbaum

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. gie-area/conformance Categorizes an issue or PR as relevant to GIE conformance tests. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zetxqx @k8s-ci-robot @nirrozenbaum @robscott